Changeset 1315 for trunk/Sources/PGTSQuery.m

Timestamp:

06/29/09 14:37:31 (13 months ago)

Author:

tsnorri

Message:

Changed calls to CFRetain and CFRelease as per Apple's recommendation
- Fixes #209.

Files:

• trunk/Sources/PGTSQuery.m (modified) (4 diffs)

trunk/Sources/PGTSQuery.m

@@ -150 +150 @@
 {
         NSMutableString* desc = [NSMutableString string];
-        CFRetain (desc);
         for (int i = 0; i < nParams; i++)
         {
@@ -162 +161 @@
         }
         char* retval = strdup ([desc UTF8String] ?: "");
-        CFRelease (desc);
+        
+        //For GC.
+        [desc self];
         return retval;
 }
@@ -175 +176 @@
                 NSUInteger nParams = [self parameterCount];
                 NSArray* parameterObjects = [[mParameters PGTSCollect] PGTSParameter: connection];
-                if (parameterObjects) CFRetain (parameterObjects);
                 
                 const char** paramValues  = calloc (nParams, sizeof (char *));
@@ -217 +217 @@
                         [(id) [connection delegate] PGTSConnection: connection sentQuery: self];
                 
-                if (parameterObjects) CFRelease (parameterObjects);
                 free (paramTypes);
                 free (paramValues);
                 free (paramLengths);
                 free (paramFormats);
+
+                //For GC.
+                [parameterObjects self];
         }
     return retval;